remove ANDROID_SDK_HOME, ANDROID_NDK_HOME env vars #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Those for for compatibility reasons. I don't think removing them is a good idea. |
gengjiawen
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit 1b7e96b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NDK is used in the image, there is ANDROID_NDK_HOME deprecation warning. And found that it's not correct to point ANDROID_SDK_HOME to ANDROID_HOME, because they serve different purposes. Please skim into https://developer.android.com/studio/command-line/variables